[PATCH 1/4] sim: Add ATTRIBUTE_PRINTF

Tsukasa OI research_trasio@irq.a4lg.com
Tue Sep 13 12:57:29 GMT 2022


Clang generates a warning if the format parameter of a printf-like function
is not a literal.  To avoid warnings on printf-like wrapper, it requires
__attribute__((format)) and we have ATTRIBUTE_PRINTF macro.  Because of the
default configuration ("-Werror"), it causes a build failure.

This commit adds ATTRIBUTE_PRINTF for a printf-like function.

sim/ChangeLog:

	* common/sim-cpu.h (sim_io_eprintf_cpu): Add ATTRIBUTE_PRINTF.
---
 sim/common/sim-cpu.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sim/common/sim-cpu.h b/sim/common/sim-cpu.h
index d8b2b9c494a..024eb31d79a 100644
--- a/sim/common/sim-cpu.h
+++ b/sim/common/sim-cpu.h
@@ -137,7 +137,8 @@ extern sim_cpu *sim_cpu_lookup (SIM_DESC, const char *);
 /* Return prefix to use in cpu specific messages.  */
 extern const char *sim_cpu_msg_prefix (sim_cpu *);
 /* Cover fn to sim_io_eprintf.  */
-extern void sim_io_eprintf_cpu (sim_cpu *, const char *, ...);
+extern void sim_io_eprintf_cpu (sim_cpu *, const char *, ...)
+    ATTRIBUTE_PRINTF (2, 3);
 
 /* Get/set a pc value.  */
 #define CPU_PC_GET(cpu) ((* CPU_PC_FETCH (cpu)) (cpu))
-- 
2.34.1



More information about the Gdb-patches mailing list