[PATCH v2] sim, sim/{m32c,ppc,rl78}: Use getopt_long
Tsukasa OI
research_trasio@irq.a4lg.com
Tue Oct 25 06:27:22 GMT 2022
Because of Binutils/GCC hack, getopt on GNU libc (2.25 or earlier) is
currently unusable on sim, causing a regression on CentOS 7.
This is caused as follows:
1. If HAVE_DECL_GETOPT is defined (getopt with known prototype is
declared), a declaration of getopt in "include/getopt.h" is suppressed.
The author started to define HAVE_DECL_GETOPT in sim with the commit
340aa4f6872c ("sim: Check known getopt definition existence").
2. GNU libc (2.25 or earlier)'s <unistd.h> includes <getopt.h> to declare
getopt function (only, not getopt_long or getopt_long_only) but it
causes <unistd.h> to include Binutils/GCC's "include/getopt.h".
3. If both 1. and 2. are satisfied, despite that <unistd.h> tries to
declare getopt by including <getopt.h>, "include/getopt.h" does not
define one, causing getopt function unusable.
Getting rid of "include/getopt.h" (e.g. renaming this header file) is the
best solution to avoid hacking but as a short-term solution, this commit
replaces getopt with getopt_long under sim/.
---
sim/igen/igen.c | 6 ++++--
sim/m32c/main.c | 5 ++++-
sim/ppc/dgen.c | 6 ++++--
sim/ppc/igen.c | 9 ++++++---
sim/rl78/main.c | 4 +++-
5 files changed, 21 insertions(+), 9 deletions(-)
diff --git a/sim/igen/igen.c b/sim/igen/igen.c
index ba856401fa9..22cfd30ec43 100644
--- a/sim/igen/igen.c
+++ b/sim/igen/igen.c
@@ -989,6 +989,7 @@ main (int argc, char **argv, char **envp)
char *real_file_name = NULL;
int is_header = 0;
int ch;
+ struct option dummy_longopts = { 0 };
lf *standard_out =
lf_open ("-", "stdout", lf_omit_references, lf_is_text, "igen");
@@ -1162,8 +1163,9 @@ main (int argc, char **argv, char **envp)
printf (" -t <output-file> output itable\n");
}
- while ((ch = getopt (argc, argv,
- "B:D:F:G:H:I:M:N:P:T:W:o:k:i:n:hc:d:e:m:r:s:t:f:x"))
+ while ((ch = getopt_long (argc, argv,
+ "B:D:F:G:H:I:M:N:P:T:W:o:k:i:n:hc:d:e:m:r:s:t:f:x",
+ &dummy_longopts, NULL))
!= -1)
{
#if 0 /* For debugging. */
diff --git a/sim/m32c/main.c b/sim/m32c/main.c
index 958ca27ab2b..5560adea60a 100644
--- a/sim/m32c/main.c
+++ b/sim/m32c/main.c
@@ -29,6 +29,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include <setjmp.h>
#include <signal.h>
#include <sys/types.h>
+#include <getopt.h>
#ifdef HAVE_SYS_SOCKET_H
#ifdef HAVE_NETINET_IN_H
@@ -135,12 +136,14 @@ main (int argc, char **argv)
#ifdef HAVE_networking
char *console_port_s = 0;
#endif
+ struct option dummy_longopts = { 0 };
setbuf (stdout, 0);
in_gdb = 0;
- while ((o = getopt (argc, argv, "tc:vdm:C")) != -1)
+ while ((o = getopt_long (argc, argv, "tc:vdm:C", &dummy_longopts, NULL))
+ != -1)
switch (o)
{
case 't':
diff --git a/sim/ppc/dgen.c b/sim/ppc/dgen.c
index a1c1d56e8dc..da0b6446cfa 100644
--- a/sim/ppc/dgen.c
+++ b/sim/ppc/dgen.c
@@ -271,6 +271,7 @@ main(int argc,
{
lf_file_references file_references = lf_include_references;
spreg_table *sprs = NULL;
+ struct option dummy_longopts = { 0 };
char *real_file_name = NULL;
int is_header = 0;
int ch;
@@ -284,8 +285,9 @@ main(int argc,
printf("-L Suppress cpp line numbering in output files\n");
}
-
- while ((ch = getopt(argc, argv, "hLsn:r:p:")) != -1) {
+ while ((ch = getopt_long (argc, argv, "hLsn:r:p:", &dummy_longopts, NULL))
+ != -1)
+ {
#if 0 /* For debugging. */
fprintf(stderr, "\t-%c %s\n", ch, ( optarg ? optarg : ""));
#endif
diff --git a/sim/ppc/igen.c b/sim/ppc/igen.c
index 27b48638276..35d222df34b 100644
--- a/sim/ppc/igen.c
+++ b/sim/ppc/igen.c
@@ -351,6 +351,7 @@ main(int argc,
filter *filters = NULL;
insn_table *instructions = NULL;
table_include *includes = NULL;
+ struct option dummy_longopts = { 0 };
char *real_file_name = NULL;
int is_header = 0;
int ch;
@@ -390,9 +391,11 @@ main(int argc,
printf(" -f <output-file> output support functions\n");
}
- while ((ch = getopt(argc, argv,
- "F:EI:RSLJT:CB:H:N:o:k:i:n:hc:d:m:s:t:f:"))
- != -1) {
+ while (
+ (ch = getopt_long (argc, argv, "F:EI:RSLJT:CB:H:N:o:k:i:n:hc:d:m:s:t:f:",
+ &dummy_longopts, NULL))
+ != -1)
+ {
#if 0 /* For debugging. */
fprintf(stderr, "\t-%c %s\n", ch, (optarg ? optarg : ""));
#endif
diff --git a/sim/rl78/main.c b/sim/rl78/main.c
index c9459c7bc78..436f370a338 100644
--- a/sim/rl78/main.c
+++ b/sim/rl78/main.c
@@ -64,10 +64,12 @@ main (int argc, char **argv)
int save_trace;
bfd *prog;
int rc;
+ struct option dummy_longopts = { 0 };
xmalloc_set_program_name (argv[0]);
- while ((o = getopt (argc, argv, "tvdr:D:M:")) != -1)
+ while ((o = getopt_long (argc, argv, "tvdr:D:M:", &dummy_longopts, NULL))
+ != -1)
{
switch (o)
{
base-commit: a5a0a4fd0ff536a8dbd532864cfc095a306b678c
--
2.37.2
More information about the Gdb-patches
mailing list