[PATCH v2 1/6] gdbserver: Add asserts in register_size and register_data functions
Luis Machado
luis.machado@arm.com
Mon Nov 28 11:51:30 GMT 2022
On 11/26/22 02:04, Thiago Jung Bauermann wrote:
> These helped me during development, catching bugs closer to when they
> actually happened.
> ---
> gdbserver/regcache.cc | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc
> index 5cbcea978a05..14236069f712 100644
> --- a/gdbserver/regcache.cc
> +++ b/gdbserver/regcache.cc
> @@ -286,6 +286,8 @@ register_cache_size (const struct target_desc *tdesc)
> int
> register_size (const struct target_desc *tdesc, int n)
> {
> + gdb_assert (n >= 0 && n < tdesc->reg_defs.size ());
> +
> return find_register_by_number (tdesc, n).size / 8;
> }
>
> @@ -300,6 +302,8 @@ regcache_register_size (const struct regcache *regcache, int n)
> static unsigned char *
> register_data (const struct regcache *regcache, int n)
> {
> + gdb_assert(n >= 0 && n < regcache->tdesc->reg_defs.size());
> +
> return (regcache->registers
> + find_register_by_number (regcache->tdesc, n).offset / 8);
> }
LGTM.
Reviewed-by: Luis Machado <luis.machado@arm.com>
More information about the Gdb-patches
mailing list