[PATCH v2 00/16] Fortran compiler identification and ifx testsuite support

[Andrew Burgess]

Nils-Christian Kempke via Gdb-patches <gdb-patches@sourceware.org>
writes:

> Hi,
>
> V1 of this series can be found here:
>
>   https://sourceware.org/pipermail/gdb-patches/2022-May/188904.html
>
> Changes since v1:
>
>   * Patch 03: There were some leftovers in the commit message from an
>   earlier version of the patch - these have been removed.
>
>   * Patch 04: The commit message has been renamed and a comment been
>   adapted according to Andrew's feedback.  The getting_compiler_info
>   variable now also uses actual bool values.
>
>   * Patch 06: The commit message has been adapted and now says that
>   the intel C compiler names have not yet been used in the testsuite (to
>   avoid confusion as to why there are no changes done in the testsuite).
>
>   * Patch 08: This patch has been dropped, instead an ifx bug was filed.
>   So from now on the patch numbers will be off by 1.
>
>   * Patch 11 (now 10): The comment has been reworded and
>     'need the -debug-parameters all flag set to emit'
>   now reads
>     'need the -debug-parameters flag set to emit' 
>   Also, not only ifx but also ifort requires the flag so it is now added
>   for both compilers.
>
>   * Patch 13 (now 12): I added a comment to the patch as well as made
>   the commit message a lot more elaborate (after some online
>   discussion).
>
>   * Patch 14: This patch has been dropped for now as we are claifying
>   whether ifx should change its debug output.  The patch numbers will
>   now be off by 2. 
>
>   * Patch 18 (now 16): The '-wrap' is now used here instead of adding
>   the $gdb_prompt in test_multiple.  Also, flang was added to the
>   comments.
>
> Patch 01, 02, 05, 07, 09 (now 08), 10 (now 09), 12 (now 11), 15 (now 13),
> 16 (now 14), and 17 (now 15) had been approved before and were not
> changed/included here.

I've approved all these patches now.

For me I would have preferred to see the complete set of patches
included each time the series is reposted, it makes it easier to apply
the patches.  Though I do also appreciate you commenting about which
patches have changed, and what the changes were.

Thanks,
Andrew


>
> I am happy about any feedback.
>
> Cheers,
>
> Nils
>
> Abdul Basit Ijaz (1):
>   gdb/testsuite: Use -module option for Intel Fortran compilers
>
> Cristian Sandu (1):
>   gdb/testsuite: add Fortran compiler identification to GDB
>
> Felix Willgerodt (1):
>   gdb/testsuite: Fix fortran types for Intel compilers.
>
> Nils-Christian Kempke (13):
>   gdb/testsuite: remove F77_FOR_TARGET support
>   gdb/testsuite: move getting_compiler_info to front of gdb_compile
>   gdb/testsuite: rename intel next gen c/cpp compilers
>   gdb/testsuite: disable charset.exp for intel compilers
>   testsuite, fortran: add required external keyword
>   testsuite, fortran: add compiler dependent types to
>     dynamic-ptype-whatis
>   testsuite, fortran: Add '-debug-parameters all' when using ifx/ifort
>   testsuite/lib: add check_optional_entry for GDBInfoSymbols
>   testsuite, fortran: fix info-types for intel compilers
>   testsuite, fortran: allow additional completions in module.exp
>   gdb, testsuite, fortran: fix double free in mixed-lang-stack.exp
>   gdb, testsuite, fortran: fixup mixed-lang-stack for Intel/LLVM
>     compilers
>   gdb/testsuite: fixup common-block.exp for intel compilers
>
>  gdb/testsuite/boards/cc-with-tweaks.exp       |   5 -
>  gdb/testsuite/boards/debug-types.exp          |   1 -
>  gdb/testsuite/boards/gold-gdb-index.exp       |   1 -
>  gdb/testsuite/gdb.fortran/assumedrank.exp     |   6 +-
>  gdb/testsuite/gdb.fortran/charset.exp         |   5 +
>  .../gdb.fortran/class-allocatable-array.exp   |   4 +-
>  gdb/testsuite/gdb.fortran/common-block.exp    |  38 ++++++-
>  .../gdb.fortran/derived-type-striding.exp     |   2 +-
>  .../gdb.fortran/dynamic-ptype-whatis.exp      |  79 +++++++-------
>  gdb/testsuite/gdb.fortran/function-calls.f90  |   1 +
>  gdb/testsuite/gdb.fortran/info-types.exp      |  20 +++-
>  gdb/testsuite/gdb.fortran/library-module.exp  |   2 +-
>  .../gdb.fortran/mixed-lang-stack.cpp          |  12 +--
>  .../gdb.fortran/mixed-lang-stack.exp          |  21 ++--
>  gdb/testsuite/gdb.fortran/module.exp          |   5 +-
>  gdb/testsuite/gdb.fortran/namelist.exp        |   2 +-
>  gdb/testsuite/gdb.fortran/nested-funcs-2.exp  |   3 +-
>  .../gdb.fortran/ptype-on-functions.exp        |   6 +-
>  gdb/testsuite/gdb.fortran/vla-type.exp        |   2 +-
>  gdb/testsuite/lib/compiler.F90                |  69 ++++++++++++
>  gdb/testsuite/lib/compiler.c                  |   2 +-
>  gdb/testsuite/lib/compiler.cc                 |   2 +-
>  gdb/testsuite/lib/fortran.exp                 | 100 +++++++++++-------
>  gdb/testsuite/lib/future.exp                  |  21 +---
>  gdb/testsuite/lib/gdb.exp                     |  62 +++++++----
>  gdb/testsuite/lib/sym-info-cmds.exp           |  18 +++-
>  26 files changed, 318 insertions(+), 171 deletions(-)
>  create mode 100644 gdb/testsuite/lib/compiler.F90
>
> -- 
> 2.25.1
>
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928