[pushed] gdb/testsuite: fix gdb.trace/signal.exp on x86

Andrew Burgess aburgess@redhat.com
Tue May 31 08:24:32 GMT 2022


Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

> From: Simon Marchi <simon.marchi@efficios.com>
>
> Patch
>
>   202be274a41a ("opcodes/i386: remove trailing whitespace from insns with zero operands")
>
> causes this regression:
>
>   FAIL: gdb.trace/signal.exp: find syscall insn in kill
>
> It's because the test still expects to match a whitespace after the
> instruction, which the patch mentioned above removed.  Remove the
> whitespaces for the regexp.

Thanks for fixing this.

Andrew

>
> Change-Id: Ie194273cc942bfd91332d4035f6eec55b7d3a428
> ---
>  gdb/testsuite/gdb.trace/signal.exp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.trace/signal.exp b/gdb/testsuite/gdb.trace/signal.exp
> index e5b608974869..782abeb69d38 100644
> --- a/gdb/testsuite/gdb.trace/signal.exp
> +++ b/gdb/testsuite/gdb.trace/signal.exp
> @@ -55,7 +55,7 @@ set syscall_insn ""
>  # Define the syscall instruction for each target.
>  
>  if { [istarget "i\[34567\]86-*-linux*"] || [istarget "x86_64-*-linux*"] } {
> -    set syscall_insn "\[ \t\](int|syscall|sysenter)\[ \t\]"
> +    set syscall_insn "\[ \t\](int|syscall|sysenter)"
>  } elseif { [istarget "aarch64*-*-linux*"] || [istarget "arm*-*-linux*"] } {
>      set syscall_insn "\[ \t\](swi|svc)\[ \t\]"
>  } else {
>
> base-commit: 5541bfdc97936581c0ead915e9117e22f21bdb12
> -- 
> 2.36.1



More information about the Gdb-patches mailing list