[PATCH 0/7] location -> location spec

Pedro Alves pedro@palves.net
Fri May 27 18:02:41 GMT 2022


Currently, GDB internally uses the term "location" for both the
location specification the user had input, and for actual resolved
locations, like the breakpoint locations, or the result of decoding a
location spec to SaLs.  This is expecially confusing in the
breakpoints module.

For the location spec, we currently have struct "event_location", and
even the "event" part is misnamed.

This series everything related to location specifications from
"location" to "location spec".  event_location is renamed to
location_spec.  And then cleans up location_spec and its subclasses.

Tested on x86_64 GNU/Linux.

Pedro Alves (7):
  event_location -> location_spec
  Eliminate the two-level data structures behind location_specs
  Eliminate copy_location_spec
  Convert location_spec_empty_p to a method
  Convert location_spec_type to a method
  Convert location_spec_to_string to a method
  Convert set_location_spec_string to a method

 gdb/ada-lang.c                   |   4 +-
 gdb/ax-gdb.c                     |   6 +-
 gdb/break-catch-throw.c          |  17 +-
 gdb/breakpoint.c                 | 367 +++++++++--------
 gdb/breakpoint.h                 |  62 +--
 gdb/cli/cli-cmds.c               |  32 +-
 gdb/completer.c                  |  42 +-
 gdb/elfread.c                    |   3 +-
 gdb/guile/scm-breakpoint.c       |  21 +-
 gdb/linespec.c                   | 157 ++++----
 gdb/linespec.h                   |  12 +-
 gdb/location.c                   | 662 ++++++++++++-------------------
 gdb/location.h                   | 359 ++++++++++-------
 gdb/mi/mi-cmd-break.c            |  35 +-
 gdb/probe.c                      |   8 +-
 gdb/probe.h                      |   4 +-
 gdb/python/py-breakpoint.c       |  39 +-
 gdb/python/py-finishbreakpoint.c |   6 +-
 gdb/python/python.c              |  10 +-
 gdb/remote.c                     |   6 +-
 gdb/tracepoint.c                 |   6 +-
 21 files changed, 877 insertions(+), 981 deletions(-)


base-commit: 509e6230915a050d510a36ca9482193c76a6a216
-- 
2.36.0



More information about the Gdb-patches mailing list