[PATCH 20/23] Momentary breakpoints should have no breakpoint number

Tom Tromey tom@tromey.com
Fri May 20 16:00:20 GMT 2022


>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:

Pedro> Momentary breakpoints have no breakpoint number, their breakpoint
Pedro> number should be always 0, to avoid constantly incrementing (or
Pedro> decrementing) the internal breakpoint count.

Pedro> Indeed, set_momentary_breakpoint installs the created breakpoint
Pedro> without a number.

Pedro> However, momentary_breakpoint_from_master incorrectly gives an
Pedro> internal breakpoint number to the new breakpoint.  This commit fixes
Pedro> that.

I think it would probably be good to document this somewhere.
Like, maybe the deleted line could be replaced with a comment.

Tom


More information about the Gdb-patches mailing list