[PATCH] gdbserver: Remove srv_linux_usrregs setting in RISCV

Palmer Dabbelt palmer@dabbelt.com
Fri May 13 16:32:23 GMT 2022


On Mon, 09 May 2022 07:17:18 PDT (-0700), tom@tromey.com wrote:
>>>>>> Youling Tang <tangyouling@loongson.cn> writes:
>
>> In the linux kernel code of RISCV, ptrace does not have the implementation
>> of PTRACE_POKEUSR/PTRACE_PEEKUSR in the arch_ptrace function (like aarch64),
>> If srv_linux_usrregs is set to yes, HAVE_LINUX_USRREGS will be defined, so
>> remove the srv_linux_usrregs setting.
>
> Looks reasonable to me.

For some reason Maciej's email is only showing up in my gmail, so I'm 
just pasting in

>  Yeah, it must have been an oversight.  Thanks for the fix!

IIRC we had some out-of-tree ptrace() implementations that were to the 
old style, but they never made it upstream.  I bet the GDB support just 
stuck around, but I don't see a reason to keep it.


More information about the Gdb-patches mailing list