[PATCH 2/2] gas/write: extend fx_pcrel_adjust to 16 bits

Dmitry Selyutin ghostmansd@gmail.com
Thu May 12 07:47:16 GMT 2022


On Wed, May 11, 2022 at 9:13 PM Andreas Schwab <schwab@linux-m68k.org> wrote:
> It's probably better to swap the fx_size and fx_pcrel_adjust fields, so
> that fx_pcrel_adjust is aligned on a 16 bit boundary.

Thank you for your suggestion! After thinking about it for a while, I
suggest moving the fx_pcrel_adjust (16 bits) field to the top, then
putting fx_size (8 bits), then the rest.
Also, I'd replace `unsigned fx_unused : 2` with a simple `unsigned :
2`, I think this way we can make it even clearer that these bits are
spare. But perhaps this should go as a separate change.


More information about the Gdb-patches mailing list