[PATCH 08/18] testsuite, fortran: make print-formatted.exp more robust

[Kempke, Nils-Christian]

> -----Original Message-----
> From: Andrew Burgess <aburgess@redhat.com>
> Sent: Wednesday, May 11, 2022 1:32 PM
> To: Kempke, Nils-Christian <nils-christian.kempke@intel.com>; gdb-
> patches@sourceware.org
> Cc: JiniSusan.George@amd.com
> Subject: Re: [PATCH 08/18] testsuite, fortran: make print-formatted.exp
> more robust
> 
> Nils-Christian Kempke via Gdb-patches <gdb-patches@sourceware.org>
> writes:
> 
> > The test was written in a way that assumed, that going to main and
> > issuing a single next command would automatically end up after the
> > assign statement for ii.  This was true for gfortran and ifort, but not
> > for ifx leading to a failed test.  For ifx, GDB actually was at
> > the assign statment (not past it) and printing 'ii' there would lead to
> > GDB displaying it as 0 (instead of 10), failing the test.
> >
> > I changed this to become more robust and added a line past the
> > assignment with a comment, as is commonly done all over the testsuite.
> >
> > After this change the test passes for all, gfortran/ifort/ifx/flang.
> 
> I have no problem with this change, the point of the test is clearly the
> print formatting rather than the behaviour of 'next'.
> 
> That said, isn't the behaviour for ifx indicating a bug in the generated
> debug info?  The program only has the single 'ii = 10' statement, so
> surely when we run to main, that's where we should stop?  Then 'next'
> should move past that line?
> 
> If you agree then it might be worth mentioning that this is working
> around the compiler bug.
> 

You are completely right here. We also think this is an ifx bug. In this light,
I would rather like to drop this patch from this series. We'll instead work on
fixing this bug in ifx.

Thanks,
Nils

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928