[PATCH] gdb, btrace: Throw an error for empty recordings when replaying starts.

Andrew Burgess aburgess@redhat.com
Wed May 11 09:33:34 GMT 2022


Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org> writes:

> This makes record_btrace_start_replaying() more consistent, as it already
> errors out e.g. on a recording with only gaps.
> ---
>  gdb/record-btrace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c
> index 373d82b8b99..3f8a69dd04f 100644
> --- a/gdb/record-btrace.c
> +++ b/gdb/record-btrace.c
> @@ -2017,7 +2017,7 @@ record_btrace_start_replaying (struct thread_info *tp)
>  
>    /* We can't start replaying without trace.  */
>    if (btinfo->functions.empty ())
> -    return NULL;
> +    error (_("No trace."));
>  
>    /* GDB stores the current frame_id when stepping in order to detects steps
>       into subroutines.

Please can you add a test for this change.

Thanks,
Andrew



More information about the Gdb-patches mailing list