[PATCH v4 07/10] btrace, gdbserver: Add ptwrite to btrace_config_pt.
Willgerodt, Felix
felix.willgerodt@intel.com
Tue May 10 13:42:52 GMT 2022
> -----Original Message-----
> From: Eli Zaretskii <eliz@gnu.org>
> Sent: Freitag, 6. Mai 2022 13:54
> To: Willgerodt, Felix <felix.willgerodt@intel.com>
> Cc: Metzger, Markus T <markus.t.metzger@intel.com>; gdb-
> patches@sourceware.org
> Subject: Re: [PATCH v4 07/10] btrace, gdbserver: Add ptwrite to
> btrace_config_pt.
>
> > Date: Fri, 6 May 2022 13:40:07 +0200
> > From: Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
> >
> > +@item Qbtrace-conf:pt:ptwrite=@var{value}
> > +Control recording of ptwrite packets. This was added for backwards-
> > +compatibility.
>
> Suggest to rephrase the second sentence to remove "was added". The
> manual is supposed to describe the current situation, not the history
> (which becomes less and less relevant as time goes by).
>
> The documentation part is okay with this not fixed.
>
> Thanks.
I fixed it locally to say "This allows for backwards-compatibility".
Thanks,
Felix
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
More information about the Gdb-patches
mailing list