[PATCH 18/18] Introduce catchpoint class

[Simon Marchi]

On 2022-05-02 18:15, Tom Tromey wrote:
> This introduces a catchpoint class that is used as the base class for
> all catchpoints.  init_catchpoint is rewritten to be a constructor
> instead.
> 
> This changes the hierarchy a little -- some catchpoints now inherit
> from base_breakpoint whereas previously they did not.  This isn't a
> problem, as long as re_set is redefined in catchpoint.

Hi Tom,

This causes some regressions:

$ ./gdb -q --data-directory=data-directory -nx -ex "catch syscall"
/home/smarchi/src/binutils-gdb/gdb/break-catch-syscall.c:295:34: runtime error: member access within null pointer of type 'struct bp_location'

The affected tests are

gdb.base/catch-syscall.exp
gdb.guile/scm-breakpoint.exp
gdb.mi/mi-breakpoint-changed.exp

Simon