[PATCHv3 0/3] Add Type.is_scalar and Type.is_signed properties

[Andrew Burgess]

Tom Tromey <tom@tromey.com> writes:

>>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Andrew> Thanks for all the feedback on V1, and V2.  Additionally, Simon gave
> Andrew> some awesome suggestions on IRC
>
> Andrew> The new V3 series is a complete rewrite, main points are:
>
> Andrew>   - New Type.is_scalar property in patch #1,
>
> Andrew>   - Now have a Type.is_signed property (patch #2), which is either
> Andrew>     True or False.  Attempting to read this property on a non-scalar
> Andrew>     type will raise a ValueError.
>
> Andrew>   - Finally, patch #3 adds a test for to cover the 'char' is different
> Andrew>     to 'signed char' and 'unsigned char' issue.  This characteristic
> Andrew>     should be detected by simply comparing types.
>
> Andrew> Thoughts?
>
> It all looks reasonable to me.  Thank you.

I pushed this series.

Thanks,
Andrew