[PATCH v5 05/10] python: Introduce gdb.RecordAuxiliary class.

[Metzger, Markus T]

Hello Felix,

>+  if (insn->iclass == BTRACE_INSN_AUX)
>+    return recpy_aux_new (
>+	iter.btinfo->aux_data.at (insn->aux_data_index).c_str (), number);

The formatting looks off.  It should be broken at the 2nd argument.


>@@ -64,6 +70,18 @@ struct recpy_gap_object
>   Py_ssize_t number;
> };
>
>+/* Python RecordAuxiliary object.  */
>+typedef struct
>+{
>+  PyObject_HEAD
>+
>+  /* Auxiliary data.  */
>+  const char *data;

Should this be a std::string instead of referencing the C string in the AUX_DATA?

regards,
markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928