[PATCH v2 1/2] gdb/testsuite: rename get_maint_bp_addr and move it to gdb-utils.exp

Enze Li enze.li@hotmail.com
Sun Jul 24 04:10:03 GMT 2022


On Fri, 2022-07-15 at 10:25 -0600, Tom Tromey wrote:
> > > > > > "Enze" == Enze Li via Gdb-patches
> > > > > > <gdb-patches@sourceware.org> writes:
> 
> Enze> The get_maint_bp_addr procedure will be shared by other test
> suite, so
> Enze> move it to gdb-utils.exp.
> 
> Enze> Following Andrew's suggestion, I renamed get_maint_bp_addr to
> Enze> gdb_get_bp_addr, since it would have handled normal breakpoints
> in
> Enze> addition to the internal ones.  Note that there is still room
> for
> Enze> improvement in this procedure, which I indicated in comments
> nearby.
> 
> This looks good to me, thanks.
> 
> Tom

Hi Tom,

Thanks for your review.  I'm checking these in now.

Best Regards,
Enze



More information about the Gdb-patches mailing list