[PATCH] [PATCH] [gdb] adds `<iterator>` to list of includes

Andrew Burgess aburgess@redhat.com
Sat Jul 9 09:10:40 GMT 2022


* Christopher Di Bella via Gdb-patches <gdb-patches@sourceware.org> [2022-06-28 01:04:27 +0000]:

> `std::back_inserter` is defined in `<iterator>`, which is currently
> being transitively included by one of the other headers. This is causing
> gdb to fail to build on certain platforms, which is fixed by explicitly
> including it.

Hi Christopher,

Thanks for this fix.  If you could update the commit message with the
additional information that Manoj provided then repost, and we can get
this merged.

Thanks,
Andrew



> ---
>  gdb/value.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/gdb/value.c b/gdb/value.c
> index 022fca91a42..ba7ae1a0e18 100644
> --- a/gdb/value.c
> +++ b/gdb/value.c
> @@ -40,6 +40,7 @@
>  #include "cp-abi.h"
>  #include "user-regs.h"
>  #include <algorithm>
> +#include <iterator>
>  #include "completer.h"
>  #include "gdbsupport/selftest.h"
>  #include "gdbsupport/array-view.h"
> -- 
> 2.37.0.rc0.161.g10f37bed90-goog
> 



More information about the Gdb-patches mailing list