[PATCH 11/12] gdb/testsuite: Remove duplicates from gdb.mi/mi2-amd64-entry-value.exp

Pedro Alves pedro@palves.net
Thu Jan 6 16:49:10 GMT 2022


On 2021-12-17 22:57, Lancelot SIX wrote:
>>
>> IWBN to get this grouped properly while at it.  Would you mind removing the "only:" etc.
>> manual prefixes instead, converting that to the with_test_prefix prefix?  Like:
>>
>> with_test_prefix "only" {
>>     if {[mi_runto_main] == -1} {
>> 	return -1
>>     }
>>
>> -   mi_gdb_test "-gdb-set print entry-values only" {\^done} "only: set print entry-values"
>> -   mi_send_resuming_command "exec-continue" "only: entry_equal: continue"
>> +  mi_gdb_test "-gdb-set print entry-values only" {\^done} "set print entry-values"
>> +  mi_send_resuming_command "exec-continue" "entry_equal: continue"
>> }
>>
>> etc?
> 
> Hi,
> 
> Yes.  Looking at the file it is posssible to go even one step further
> and have a second level of with_test_prefix.  This is what I have done
> in the revision of this patch (which makes the patch much longer, but I
> think it is worth).  See below.
> 
> Thanks,
> Lancelot.

OK.


More information about the Gdb-patches mailing list