[PATCH 10/12] Use filtered output in gnu-nat.c commands

Andrew Burgess aburgess@redhat.com
Thu Jan 6 10:07:10 GMT 2022


* Tom Tromey <tom@tromey.com> [2022-01-05 11:37:15 -0700]:

> >>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
> 
> >> +  fprintf_filtered (gdb_stderr,
> >> +		    "\"set thread\" must be followed by the "
> >> +		    "name of a thread property, or \"default\".\n");
> 
> Andrew> I'd be tempted to suggest that these should all be replaced with calls
> Andrew> to error.  If the user runs one of these from a command script, it
> Andrew> feels like hitting one of these cases should be something that stops
> Andrew> the script running due to the incorrectly formed command, rather than
> Andrew> just printing a message and continuing...
> 
> I considered that, but I didn't want to make that kind of change without
> input from someone who uses and can actually build gnu-nat.c.

I have a VM in which I can build GDB on GNU Hurd, it's pretty slow,
but I'll give this a test today.

If looks good then I'll post a patch to change these too errors.  I
have no objection to you merging this first though.

Thanks,
Andrew



More information about the Gdb-patches mailing list