[RFC][PATCH v3 1/1][PR gdb/24069] gdb/darwin: skip over WIFSTOPPED wait4 status

Simon Marchi simon.marchi@polymtl.ca
Mon Feb 28 18:34:23 GMT 2022



On 2022-02-28 12:52, Philippe Blain wrote:
> Hi Simon,
> 
> Le 2022-02-24 à 10:49, Simon Marchi a écrit :
>>
>>
>> On 2022-02-24 09:23, Philippe Blain wrote:
>>> From: Dominique Quatravaux <dominique.quatravaux@epfl.ch>
>>>>
>>>
>>> 	PR gdb/24609
>>> 	* gdb/darwin-nat.c (darwin_nat_target::decode_message): Also
>>> 	check for WIFSTOPPED upon MACH_NOTIFY_DEAD_NAME.
>>
>> Thanks, pushed.
>>
>> Simon
>>
> 
> I noticed that the Bugzilla entry was not updated when you pushed
> that commit, whereas it was for the previous one [1]. I'm not sure
> of what is the automation that makes this work...
> 
> I thought it was because my changelog entry mistakenly used 24609 instead
> of 24069, but that was the case also for v2 1/2, so I guess that's not
> the cause...

Patch #1 had a link to the correct bugzilla ticket in its commit message,
so the connection was made.

Patch #2 didn't have any mention of the bugzilla ticket, so there was
no connection.

The correct thing to do nowadays, according to our standard procedures,
would have been to use the:

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=24069

trailer.  But I often forget about it.

Simon




More information about the Gdb-patches mailing list