[PATCH 08/12] sim cris: Unbreak --disable-sim-hardware builds

[Mike Frysinger]

On 15 Feb 2022 00:05, Hans-Peter Nilsson via Gdb-patches wrote:
> +#if WITH_HW
>    if (cris_have_900000xxif)
>      sim_hw_parse (sd, "/core/%s/reg %#x %i", "cris_900000xx", 0x90000000, 0x100);
> +#else
> +  /* With the option disabled, nothing should be able to set this variable.
> +     We should "use" it, though, and why not assert that it isn't set.  */
> +  ASSERT (! cris_have_900000xxif);
> +#endif

WITH_HW is always defined to either 1 or 0.  could you write:
  if (WITH_HW)
    ...
  else
    ...

this avoids bit rot in the uncommon configure paths
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/gdb-patches/attachments/20220215/02491eb7/attachment.sig>