[PATCH] gdb/python: allow Value.format_string to return styled output

Andrew Burgess aburgess@redhat.com
Mon Feb 7 17:03:48 GMT 2022


Eli Zaretskii via Gdb-patches <gdb-patches@sourceware.org> writes:

>> Date: Mon, 7 Feb 2022 10:05:33 +0000
>> From: Andrew Burgess <aburgess@redhat.com>
>> Cc: gdb-patches@sourceware.org
>> 
>> Hi Eli,
>> 
>> Didn't know if you wanted to give this patch a docs review or not.
>
> Sorry I missed that.

No problem.

I pushed this with the fix you suggested.

Thanks,
Andrew

>
>> > +@item styling
>> > +@code{True} if @value{GDBN} should apply styling to the returned
>> > +string.  When styling is applied, the returned string might contain
>> > +ANSI terminal escape sequences.  Escape sequences will only be
>> > +included if styling is turned on, @xref{Output Styling}.
>                                        ^^^^^
> Please use "@pxref" or "see @ref" here.  @xref produces a capitalized
> "Note", which is not appropriate in the middle of a sentence.
>
> The documentation parts are OK with that nit fixed.



More information about the Gdb-patches mailing list