[PATCH 00/33] Remove some more accessor macros

[Simon Marchi]

On 2022-02-06 10:22, Joel Brobecker via Gdb-patches wrote:
> Hi Simon,
> 
> On Fri, Jan 28, 2022 at 07:44:58AM -0500, Simon Marchi via Gdb-patches wrote:
>> Most of this is mechanical, so probably doesn't need too much review.
>> But there are some changes near the beginning that move compunit
>> functions and methods, that's probably worth looking at.
>>
>> Simon Marchi (33):
>>   gdb: add getter/setter for compunit_symtab::objfile
>>   gdb: remove COMPUNIT_OBJFILE macro
>>   gdb: rename compunit_primary_filetab to
>>     compunit_symtab::primary_filetab
>>   gdb: add compunit_symtab::add_filetab method
>>   gdb: add compunit_symtab::set_primary_filetab method
>>   gdb: move compunit_filetabs to compunit_symtab::filetabs
>>   gdb: remove COMPUNIT_FILETABS macro
>>   gdb: remove COMPUNIT_DEBUGFORMAT macro, add getter/setter
>>   gdb: remove COMPUNIT_PRODUCER macro, add getter/setter
>>   gdb: remove COMPUNIT_DIRNAME macro, add getter/setter
>>   gdb: remove COMPUNIT_BLOCKVECTOR macro, add getter/setter
>>   gdb: remove COMPUNIT_BLOCK_LINE_SECTION macro, add getter/setter
>>   gdb: remove COMPUNIT_LOCATIONS_VALID macro, add getter/setter
>>   gdb: remove COMPUNIT_EPILOGUE_UNWIND_VALID macro, add getter/setter
>>   gdb: remove COMPUNIT_MACRO_TABLE macro, add getter/setter
>>   gdb: remove SYMTAB_COMPUNIT macro, add getter/setter
>>   gdb: remove SYMTAB_LINETABLE macro, add getter/setter
>>   gdb: remove SYMTAB_LANGUAGE macro, add getter/setter
>>   gdb: remove SYMTAB_BLOCKVECTOR macro
>>   gdb: remove SYMTAB_OBJFILE macro
>>   gdb: remove SYMTAB_PSPACE macro
>>   gdb: remove SYMTAB_DIRNAME macro
>>   gdb: remove SYMBOL_MATCHES_SEARCH_NAME
>>   gdb: remove SYMBOL_ACLASS_INDEX macro, add getter/setter
>>   gdb: remove SYMBOL_IMPL macro, add method
>>   gdb: remove SYMBOL_CLASS macro, add getter
>>   gdb: remove SYMBOL_DOMAIN macro
>>   gdb: remove SYMBOL_OBJFILE_OWNED macro
>>   gdb: remove SYMBOL_IS_ARGUMENT macro
>>   gdb: remove SYMBOL_INLINED macro
>>   gdb: remote SYMBOL_IS_CPLUS_TEMPLATE_FUNCTION macro
>>   gdb: remove SYMBOL_TYPE macro
>>   gdb: remove SYMBOL_LINE macro
> 
> Thanks for this patch series. I reviewed the compunit series untit
> you started adding the getter/setter or eliminating the macros.
> After that, I only scanned the patches (burp, 'scuse me!).
> 
> FWIW, those patches looked good to me.
> 

Thanks for checking, I will push the series shortly.

Simon