[PATCH 1/2] Move some Windows operations to worker thread

Tom Tromey tromey@adacore.com
Wed Aug 3 18:47:24 GMT 2022


>> +  HANDLE bg_thread = CreateThread (nullptr, 0, fn, this, 0, nullptr);

Eli> That zero in the 2nd argument of CreateThread means the worker thread
Eli> will get the same stack size as the value recorded in the GDB
Eli> executable file's header, which is 12MB according to my reading of
Eli> gdb/Makefile, at least in my build?  That's unlikely to be required
Eli> for this thread, so I suggest to specify a non-zero value there
Eli> instead.  I guess 64KB should be enough?

I changed it to `64 * 1024` and re-tested, and this worked ok.

Tom


More information about the Gdb-patches mailing list