[PATCH 0/4] gdb, btrace: infrun fixes

[Metzger, Markus T]

ping

>-----Original Message-----
>From: Metzger, Markus T <markus.t.metzger@intel.com>
>Sent: Wednesday, July 28, 2021 8:42 AM
>To: gdb-patches@sourceware.org
>Cc: Simon Marchi <simon.marchi@polymtl.ca>; tom@tromey.com; Pedro Alves
><pedro@palves.net>
>Subject: RE: [PATCH 0/4] gdb, btrace: infrun fixes
>
>Ping.
>
>>-----Original Message-----
>>From: Metzger, Markus T <markus.t.metzger@intel.com>
>>Sent: Tuesday, June 8, 2021 11:06 AM
>>To: Simon Marchi <simon.marchi@polymtl.ca>; tom@tromey.com; Pedro Alves
>><pedro@palves.net>
>>Cc: gdb-patches@sourceware.org
>>Subject: RE: [PATCH 0/4] gdb, btrace: infrun fixes
>>
>>Thanks, Simon,
>>
>>Adding Pedro and Tom.  Maybe they can help review the infrun changes or
>>recommend
>>someone who is familiar with that code.
>>
>>Regards,
>>Markus.
>>
>>>> This small patch series fixes a few issues around reverse/replay stepping that
>>>> result in hangs.
>>>>
>>>> Tested with record btrace on IA.
>>>>
>>>> Markus Metzger (4):
>>>>   gdb, infrun, btrace: fix reverse/replay stepping at end of execution
>>>>     history
>>>>   gdb, infrun, record: fix hang when step-over fails with no-history
>>>>   gdb, infrun, record: move no-history notification into normal_stop
>>>>   gdb, infrun: fix multi-threaded reverse stepping
>>>>
>>>>  gdb/gdbthread.h                               |   7 ++
>>>>  gdb/infrun.c                                  |  87 +++++++++++----
>>>>  gdb/record-btrace.c                           |  19 ++--
>>>>  gdb/testsuite/gdb.btrace/cont-hang.exp        |  47 ++++++++
>>>>  .../gdb.btrace/implicit-stop-replaying.exp    | 105 ++++++++++++++++++
>>>>  .../gdb.btrace/multi-thread-break-hang.exp    |  92 +++++++++++++++
>>>>  gdb/testsuite/gdb.btrace/step-hang.exp        |  46 ++++++++
>>>>  gdb/testsuite/gdb.btrace/stepn.exp            |  56 ++++++++++
>>>>  8 files changed, 430 insertions(+), 29 deletions(-)
>>>>  create mode 100644 gdb/testsuite/gdb.btrace/cont-hang.exp
>>>>  create mode 100644 gdb/testsuite/gdb.btrace/implicit-stop-replaying.exp
>>>>  create mode 100644 gdb/testsuite/gdb.btrace/multi-thread-break-hang.exp
>>>>  create mode 100644 gdb/testsuite/gdb.btrace/step-hang.exp
>>>>  create mode 100644 gdb/testsuite/gdb.btrace/stepn.exp
>>>>
>>>
>>>I went through the patches.  I know next to nothing about the reverse
>>>execution mechanism, and don't really have time these days to get up to
>>>speed to understand the problems and associated fixes, so I hope that
>>>someone more qualified can take a look and approve (although I know that
>>>this area has not been touched by many people, so I don't know who that
>>>would be).
>>>
>>>All I can say is that the tests look well written and adequately
>>>commented, such that if I ever had to debug them, I would be able to
>>>understand the original intentions.
>>>
>>>Simon
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928