[PATCH 2/2] Fix ARMv8.4 for hw watchpoint and breakpoint

Luis Machado luis.machado@linaro.org
Thu Oct 21 18:08:51 GMT 2021


Hi,

On 10/21/21 2:35 PM, apinski--- via Gdb-patches wrote:
> From: Andrew Pinski <apinski@marvell.com>
> 
> Just like my previoius patch for ARMv8.1 and v8.2 (49ecef2a7da2ee9df4),
> this adds ARMv8.4 debug arch as being compatible for hw watchpoint
> and breakpoints.
> 
> gdb/ChangeLog:
> 
> 	* nat/aarch64-linux-hw-point.h (AARCH64_DEBUG_ARCH_V8_4):
> 	New define.
> 	* nat/aarch64-linux-hw-point.c (compatible_debug_arch):
> 	Return true for AARCH64_DEBUG_ARCH_V8_4.

No ChangeLog needed.

> ---
>   gdb/nat/aarch64-linux-hw-point.c | 2 ++
>   gdb/nat/aarch64-linux-hw-point.h | 1 +
>   2 files changed, 3 insertions(+)
> 
> diff --git a/gdb/nat/aarch64-linux-hw-point.c b/gdb/nat/aarch64-linux-hw-point.c
> index d8642931ac1..3a97d210ca2 100644
> --- a/gdb/nat/aarch64-linux-hw-point.c
> +++ b/gdb/nat/aarch64-linux-hw-point.c
> @@ -780,6 +780,8 @@ compatible_debug_arch (unsigned int debug_arch)
>       return true;
>     if (debug_arch == AARCH64_DEBUG_ARCH_V8_2)
>       return true;
> +  if (debug_arch == AARCH64_DEBUG_ARCH_V8_4)
> +    return true;
>   
>     return false;
>   }
> diff --git a/gdb/nat/aarch64-linux-hw-point.h b/gdb/nat/aarch64-linux-hw-point.h
> index 2fc4b400ece..ad32a671967 100644
> --- a/gdb/nat/aarch64-linux-hw-point.h
> +++ b/gdb/nat/aarch64-linux-hw-point.h
> @@ -72,6 +72,7 @@
>   #define AARCH64_DEBUG_ARCH_V8 0x6
>   #define AARCH64_DEBUG_ARCH_V8_1 0x7
>   #define AARCH64_DEBUG_ARCH_V8_2 0x8
> +#define AARCH64_DEBUG_ARCH_V8_4 0x9
>   
>   /* ptrace expects control registers to be formatted as follows:
>   
> 

Thanks. This is OK.


More information about the Gdb-patches mailing list