[PATCH 3/3] gdb, gdbserver: make target_waitstatus safe

Simon Marchi simark@simark.ca
Tue Oct 12 17:28:50 GMT 2021


On 2021-10-12 1:04 p.m., John Baldwin wrote:
> I think this is a good change.  I only read over fbsd-nat.c and I think
> I like the idea.  One thing that does stick out to me is the assymetry
> in that we no longer use TARGET_WAITKIND_* for setting the status, only
> when comparing the result of kind().  I wonder if instead you might
> consider adding type specific queries (e.g. is_ignored(), is_forked())
> and removing TARGET_WAITKIND_* as a public interface entirely?

I don't mind giving it a try, but it would be as a separate patch.

Simon


More information about the Gdb-patches mailing list