[PATCH 2/3] [gdb/cli] Add "set logging enabled", deprecate "set logging on/off"

Tom de Vries tdevries@suse.de
Wed Nov 24 11:05:50 GMT 2021


On 11/24/21 11:03 AM, Tom de Vries via Gdb-patches wrote:
> +  /* Set/show logging enabled.  */
> +  set_show_commands setshow_logging_enabled_cmds
> +    = add_setshow_boolean_cmd ("enabled", class_support, &logging_enabled,
> +			       _("Enable logging."),
> +			       _("Show whether logging is enabled."),
> +			       _("help doc"),
> +			       set_logging_enabled,
> +			       show_logging_enabled,
> +			       &set_logging_cmdlist, &show_logging_cmdlist);
> +

I propose this fixup:
...
diff --git a/gdb/cli/cli-logging.c b/gdb/cli/cli-logging.c
index 3778b88865b..3fbca6ff0b0 100644
--- a/gdb/cli/cli-logging.c
+++ b/gdb/cli/cli-logging.c
@@ -261,7 +261,7 @@ The logfile is used when directing GDB's output."),
     = add_setshow_boolean_cmd ("enabled", class_support, &logging_enabled,
                               _("Enable logging."),
                               _("Show whether logging is enabled."),
-                              _("help doc"),
+                              _("When on, enable logging."),
                               set_logging_enabled,
                               show_logging_enabled,
                               &set_logging_cmdlist, &show_logging_cmdlist);
...

Thanks,
- Tom



More information about the Gdb-patches mailing list