[PATCH] gdb: fix gdbarch_tdep ODR violation

[Luis Machado]

On 11/15/21 5:43 PM, Simon Marchi wrote:
> On 2021-11-15 3:42 p.m., will schmidt wrote:
>> On Mon, 2021-11-15 at 11:29 -0500, Simon Marchi wrote:
>>> On 2021-11-15 5:45 a.m., Luis Machado via Gdb-patches wrote:
>>>> LGTM
>>>
>>> Thanks to you and John for taking a look, I pushed the patch.
>>>
>>> Simon
>>>
>>
>> Hi,
>>
>> I'm now seeing a build failure on powerpc.  (specifically ppc64le, but
>> i'm not sure it will matter which powerpc variant).
>>
>> First failure is
>>
>> ...
>>    CXX    ppc-linux-nat.o
>> ppc-linux-nat.c: In function ‘int ppc_register_u_addr(gdbarch*, int)’:
>> ppc-linux-nat.c:658:22: error: ‘struct gdbarch_tdep’ has no member
>> named ‘ppc_gp0_regnum’
>>    658 |   if (regno >= tdep->ppc_gp0_regnum
>> ...
>>
>>
>> Assorted other no-such-member errors follow.
>>
>>
>>
>> Thanks,
>> -Will
>>
> 
> Yeah, I kind of forgot to look for uses of gdbarch_tdep in native files,
> which are not built by default on x86-64 :(.  I'm working on a patch to
> fix all of them.

Yeah. I do see some breakage for native arm/aarch64 as well. Do you 
think it might be easier to revert then re-validate the new patch. I 
suppose some targets are tricky to build native files for.