[PATCH v2 00/32] Rewrite the DWARF "partial" reader

[Simon Marchi]

On 2021-11-04 2:08 p.m., Tom Tromey wrote:
> Here is v2 of my series to rewrit the DWARF partial symbol reader.
>
> You can find v1 here:
>
>     https://sourceware.org/pipermail/gdb-patches/2021-August/181624.html
>
> This update addresses all the review comments.  I believe it fixes all
> the problems that Tom de Vries found.
>
> I regression tested this on x86-64 Fedora 34.
>
> Let me know what you think.
>
> Tom
>
>

Hi Tom,

I did go through the series, I don't have any objection, and don't have
much constructive comments, because I'm not that aware of how things
work currently with partial symtabs.

What I think I understand is that with the new indexer, we gather
essentially the same information that we gather today with partial
symbols (just the information needed for doing lookups and expanding
symtabs), but store it in a data structure that is better designed,
letting us do more in parallel.  Does that sounds right?  If not, can
you explain what's the main difference?

What sounds nice with partial symtabs is that they are re-used by
different debug formats, so each format doesn't need to implement its
own data structures to manage symtab lookups and expansion.  How much is
that new DWARF indexer really DWARF-specific (the part that parses the
DWARF obviously is, but the part that holds names and stuff)?  Could it
one day be used by other debug formats?

Simon

Simon