[PATCH 1/5] gdb: make target_close check that the target isn't pushed in all inferiors

Aktemur, Tankut Baris tankut.baris.aktemur@intel.com
Fri May 7 07:44:14 GMT 2021


On Thursday, May 6, 2021 6:36 PM, Simon Marchi Wrote:
> On 2021-05-06 12:01 p.m., Aktemur, Tankut Baris wrote:
> > On Thursday, May 6, 2021 4:28 PM, Simon Marchi wrote:
> >> The target_close function currently checks that the target to be closed
> >> isn't pushed in the current inferior:
> >>
> >>     gdb_assert (!current_inferior ()->target_is_pushed (targ));
> >>
> >> When a target is closed, it's normally because its refcount has dropped
> >> to 0, because it's not used in any inferior anymore.
> >
> > Is there a missing word in this sentence?
> 
> Hmm I don't think so.  Can you point out what seems wrong with it?
> 
> Simon

After reading the sentence a few times, I convinced myself that a word
may not be missing.  Did you mean something like the following?

  Normally, a target is closed when its refcount has dropped to 0, due to
  not being used in any inferior anymore.

Anyway, not a big deal if you want to keep the original sentence.

-Baris


Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


More information about the Gdb-patches mailing list