[PATCH/committed 1/2] sim: m68hc11: warn when emul_write fails

Mike Frysinger vapier@gentoo.org
Fri May 7 03:55:13 GMT 2021


Not sure what we should do here when this fails, so just emit a warning
for now to satisfy unused result compiler warnings.  We can see if any
users actually notice here.
---
 sim/m68hc11/ChangeLog | 5 +++++
 sim/m68hc11/emulos.c  | 7 +++++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/sim/m68hc11/ChangeLog b/sim/m68hc11/ChangeLog
index 6fd984dfa995..48b54b45dea2 100644
--- a/sim/m68hc11/ChangeLog
+++ b/sim/m68hc11/ChangeLog
@@ -1,3 +1,8 @@
+2021-05-06  Mike Frysinger  <vapier@gentoo.org>
+
+	* emulos.c: Include errno.h & stdio.h.
+	(emul_write): Print a warning when the write fails.
+
 2021-05-04  Mike Frysinger  <vapier@gentoo.org>
 
 	* dv-m68hc11.c (struct m68hc11cpu): Change attach_size to unsigned int.
diff --git a/sim/m68hc11/emulos.c b/sim/m68hc11/emulos.c
index 916364f306c4..247e66871cfb 100644
--- a/sim/m68hc11/emulos.c
+++ b/sim/m68hc11/emulos.c
@@ -23,6 +23,8 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 #endif
 
 #ifndef WIN32
+#include <errno.h>
+#include <stdio.h>
 #include <sys/types.h>
 #include <sys/time.h>
 
@@ -103,8 +105,9 @@ emul_write (sim_cpu *cpu)
   while (size)
     {
       uint8 val = memory_read8 (cpu, addr);
-        
-      write(0, &val, 1);
+
+      if (write (0, &val, 1) != 1)
+	printf ("write failed: %s\n", strerror (errno));
       addr ++;
       size--;
     }
-- 
2.31.1



More information about the Gdb-patches mailing list