[PATCH 3/4] gdb: remove context parameter from add_setshow_enum_cmd

Simon Marchi simon.marchi@polymtl.ca
Sat Jun 26 01:38:02 GMT 2021



On 2021-06-25 5:09 p.m., Andrew Burgess wrote:
> * Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> [2021-06-25 16:03:21 -0400]:
> 
>> I propose removing the context parameter from add_setshow_enum_cmd.  It
>> was useful before add_setshow_enum_cmd returned both created commands,
>> as the caller couldn't easily set the context itself.  But now, I think
>> it's fine to just let the caller do it.
> 
> ChangeLog ?
> 
> As non of the other add_setshow_* commands take a context, it seems
> reasonable to me that this should not either, hence,
> 
> LGTM.
> 
> Thanks,
> Andrew

Woops, added, thanks.

Simon


More information about the Gdb-patches mailing list