[PATCH] gdb/testsuite: restore configure script

[Simon Marchi]

On 2021-06-22 2:57 p.m., Pedro Alves wrote:
> On 2021-06-22 7:11 p.m., Simon Marchi via Gdb-patches wrote:
>> Commit f99d1d37496f ("Remove gdb/testsuite/configure") removed
>> gdb/testsuite/configure, as anything gdb/testsuite/configure did could
>> be done by gdb/configure.
>>
>> There is however one use case that popped up when this changed
>> propagated to downstream consumers, to run the testsuite on an already
>> built GDB.  In the workflow of ROCm-GDB at AMD, a GDB package is built
>> in a CI job.  This GDB package is then tested on different machines /
>> hardware configurations as part of other CI jobs.  To achieve this,
>> those CI jobs only configure the testsuite directory and run "make
>> check" with an appropriate board file.
>>
>> In light of this use case, the way I see it is that gdb/testsuite could
>> be considered its own project.  It could be stored in a completely
>> different repo if we want to, it just happens to be stored inside gdb/.
>>
>> Since the only downside of having gdb/testsuite/configure is that it
>> takes a few more seconds to run, but on the other hand it's quite useful
>> for some people, I propose re-adding it.
>>
>> In a sense, this is revert of f99d1d37496f, but it's not a direct
>> git-revert, as some things have changed since.
> 
> Thanks for doing this.
> 
> FWIW, I agree this is the right thing to do.
> 
> Perhaps it would be possible to make the testsuite/configure script finish
> quicker, by having it check fewer things.  But that's something to
> investigated/done separately, of course.

Thanks, I'll wait for a comment from Tom Tromey, see if he spots some
mistake I made.

Simon