[PATCH] Fix scoped_ignore_sigpipe selftest on systems with BSD signal semantics

Pedro Alves pedro@palves.net
Tue Jun 22 19:00:31 GMT 2021


On 2021-06-22 2:49 p.m., Tom Tromey wrote:
> Pedro> Fix this by using sigaction.  I'm not adding the usual #ifdef
> Pedro> HAVE_SIGACTION goo, because I really want to believe that all systems
> Pedro> that support SIGPIPE support sigaction nowadays.  GNU/Linux, Hurd,
> Pedro> BSDs, macOS, Cygwin, DJGPP, AIX, etc., anything resembling a modern
> Pedro> Unix does support it AFAIK, only mingw does not support it, but OTOH,
> Pedro> it also doesn't define SIGPIPE.  Confirmed by cross building GDB for
> Pedro> mingw-w64.
> 
> gnulib seems to agree:
> 
> https://www.gnu.org/software/gnulib/manual/html_node/sigprocmask.html
> 

Thanks, I didn't remember to check that.  That's the sigprocmask page, but the sigaction one
(which no doubt you meant to paste) is similar.

> Pedro> We could probably remove the HAVE_SIGPROCMASK check too, actually.
> 
> Sounds good.

I'll try to remember to do that soon.


More information about the Gdb-patches mailing list