[PATCH v3 03/17] Move frame context info to dwarf_expr_context

Zaric, Zoran (Zare) Zoran.Zaric@amd.com
Fri Jun 11 17:16:03 GMT 2021


On 6/9/21 1:45 AM, Simon Marchi wrote:
> [CAUTION: External Email]
> 
>> @@ -56,6 +57,31 @@ dwarf_gdbarch_types_init (struct gdbarch *gdbarch)
>>     return types;
>>   }
>>
>> +/* Ensure that a FRAME is defined, throw an exception otherwise.
>> +
>> +   Throwing NOT_AVAILABLE_ERROR error so that a client can chose
>> +   to react differently if the evaluation ended because there
>> +   was a missing context information.  */
> 
> This comment needs to be updated (maybe just remove the second
> paragraph).
> 
> LGTM with that fixed.
> 
> Simon
> 

Thank you. This will be fixed in the next iteration.

Zoran


More information about the Gdb-patches mailing list