[PATCH 4/4] gnulib: import select

Pedro Alves pedro@palves.net
Wed Jun 9 18:12:30 GMT 2021


On 2021-06-09 5:52 p.m., Mike Frysinger wrote:
> On 09 Jun 2021 13:27, Pedro Alves wrote:

>> I've always feared that gnulib's select module would conflict with that,
>> but I don't know for sure.  In theory, we should be able to replace all
>> that code by using gnulib's select instead, though I'm not sure gnulib
>> handles some particulars like Ctrl-C interruption.
> 
> why do you think it would conflict ?  the file doesn't seem to use select()
> at all, and ser-mingw is always enabled for mingw targets.  seems like the
> func would just be ignored.

gnulib also sometimes replaces headers with their own incompatible
definitions.

Thanks,
Pedro Alves

> 
>> I think we can avoid some pain of someone tests the import on Windows before
>> merging to master.
> 
> it's already merged ;)
> 
> gdb.exe links for me for i686-w64-mingw32, but i don't really have any way of
> testing it runs, let alone run test suite.
> -mike


More information about the Gdb-patches mailing list