[PATCH] TUI disassembly window improvement - patch inline

Vasili Burdo vasili.burdo@gmail.com
Wed Jun 9 17:36:57 GMT 2021


Hi, Tom

>Also, if you do not have a copyright assignment
I don't. What should I do to get it?

>Currently, patches require a ChangeLog entry.
All your patch-related comments are addressed.
Please review the patch in attachment.

>This is "PR tui/25347"
I marked my ChangeLog entry with this PR.

>Your mailer seems to have mangled the patch.
Now, I put the patch into the attachment.

>I wonder if the title setting is correct here.
Please, look at the screenshot in attachment.

The screen now looks like this:
+--funcaname2--------- <-- function name being executed, otherwise empty.
|   funcname: <--- always on the first line.
|   address <+255> insn <-- line format <address>
<+offset-from-the-func-start> <insn>
|   address <+265> insn
|   address <+270> insn
|   funcaname2:
|   address  <+0>  insn
| > [address <+5>  insn] <-- the line being executed.
|   address <+10>  insn
+----------------------

Thanks, Vasili
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gdb-asm-new-2.png
Type: image/png
Size: 49653 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/gdb-patches/attachments/20210609/7706622c/attachment-0001.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vburdo-tui-asm.patch
Type: application/x-patch
Size: 5842 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/gdb-patches/attachments/20210609/7706622c/attachment-0001.bin>


More information about the Gdb-patches mailing list