[PATCH 3/5] gdb/python: add PendingFrame.level and Frame.level methods

Tom Tromey tom@tromey.com
Mon Jun 7 14:57:21 GMT 2021


>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> Add new methods to the PendingFrame and Frame classes to obtain the
Andrew> stack frame level for each object.

Andrew> The use of 'level' as the method name is consistent with the existing
Andrew> attribute RecordFunctionSegment.level (though this is an attribute
Andrew> rather than a method).

Andrew> For Frame/PendingFrame I went with methods as these classes currently
Andrew> only use methods, including for simple data like architecture, so I
Andrew> want to be consistent with this interface.

gdb is already inconsistent here, something we should have been more
careful about.

This looks good to me.  Thank you.

Tom


More information about the Gdb-patches mailing list