[PATCH] Fix temp-dir leakage in per-bfd-sharing.exp
Bernd Edlinger
bernd.edlinger@hotmail.de
Wed Jun 2 17:30:05 GMT 2021
Whan using clang as compiler this compile step fails due to the
unknown option "-Wl,--build-id". This leaks the already created
temp-dir.
Fixed by compiling first, and creating the temp-dir only when the
compile succeeded.
2021-06-02 Bernd Edlinger <bernd.edlinger@hotmail.de>
* gdb.dwarf2/per-bfd-sharing.exp: Fix temp-dir leakage.
---
gdb/testsuite/gdb.dwarf2/per-bfd-sharing.exp | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/gdb/testsuite/gdb.dwarf2/per-bfd-sharing.exp b/gdb/testsuite/gdb.dwarf2/per-bfd-sharing.exp
index 081088a..48a30fa 100644
--- a/gdb/testsuite/gdb.dwarf2/per-bfd-sharing.exp
+++ b/gdb/testsuite/gdb.dwarf2/per-bfd-sharing.exp
@@ -18,6 +18,11 @@
standard_testfile
+if { [build_executable "failed to prepare" $testfile $srcfile \
+ {debug additional_flags=-Wl,--build-id}] == -1 } {
+ return
+}
+
lassign [remote_exec host mktemp -d] ret cache_dir
# The output of mktemp contains an end of line, remove it.
@@ -30,11 +35,6 @@ if { $ret != 0 } {
verbose -log "Index cache dir: $cache_dir"
-if { [build_executable "failed to prepare" $testfile $srcfile \
- {debug additional_flags=-Wl,--build-id}] == -1 } {
- return
-}
-
# Populate the index-cache.
with_test_prefix "populate index cache" {
clean_restart
--
1.9.1
More information about the Gdb-patches
mailing list