[PATCH master + 11] gdb/mi: handle no condition argument case for -break-condition

[Aktemur, Tankut Baris]

From: Jonah Graham <jonah@kichwacoders.com>
Sent: Monday, July 12, 2021 3:37 PM
To: Aktemur, Tankut Baris <tankut.baris.aktemur@intel.com>
Cc: gdb-patches@sourceware.org; Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [PATCH master + 11] gdb/mi: handle no condition argument case for -break-condition

The error message has changed compared to previous GDB releases, not sure if that was intentional or if it matters, the old versions said:

^error,msg="Argument required (breakpoint number)."

the new message renders as:

^error,msg="-break-condition: Missing the <number> argument"

Eclipse CDT does not use the contents of error message (because we never send a command with such an error :-) so from my perspective it is fine to change the error message.

Jonah

The former error message was coming from the CLI’s “cond” command:

  (gdb) cond
  Argument required (breakpoint number).

In my opinion this message is equivalent to the new message in terms of descriptiveness,
except for the “-break-condition” prefix.  Let’s see what Simon or another maintainer
thinks about preserving the exact same error message.

Thanks
-Baris


Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928