[PATCH] Fix some dangling references to `netbsd-tdep`

[Simon Marchi]

On 2021-07-01 10:46 a.m., John Ericson wrote:
> These files were renamed in 1b71cfcfdc3e13a655fefa6566b5564cec044c10,
> but evidentially a few dangling references were left behind.
> 
> N.B. Originally submitted to the binutils list by mistake as
> https://sourceware.org/pipermail/binutils/2021-June/117186.html , and
> then to the non-patch GDB list as
> https://sourceware.org/pipermail/gdb/2021-July/049547.html . I am sorry,
> still getting used to this thing.

Hi!

No worries, as long as you learn in the process.  It will go smoother
next time.

> ---
>  gdb/configure.tgt | 8 ++++----
>  gdb/netbsd-tdep.c | 4 ++--
>  gdb/sparc-tdep.h  | 2 +-
>  3 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/gdb/configure.tgt b/gdb/configure.tgt
> index a928c0227a0..643973917fe 100644
> --- a/gdb/configure.tgt
> +++ b/gdb/configure.tgt
> @@ -105,7 +105,7 @@ case "${targ}" in
>  *-*-freebsd* | *-*-kfreebsd*-gnu)
>  	os_obs="fbsd-tdep.o solib-svr4.o";;
>  *-*-netbsd* | *-*-knetbsd*-gnu)
> -	os_obs="nbsd-tdep.o solib-svr4.o";;
> +	os_obs="netbsd-tdep.o solib-svr4.o";;
>  *-*-openbsd*)
>  	os_obs="obsd-tdep.o solib-svr4.o";;
>  esac
> @@ -146,7 +146,7 @@ alpha*-*-netbsd* | alpha*-*-knetbsd*-gnu)
>  alpha*-*-openbsd*)
>  	# Target: OpenBSD/alpha
>  	gdb_target_obs="alpha-mdebug-tdep.o alpha-bsd-tdep.o \
> -			alpha-netbsd-tdep.o alpha-obsd-tdep.o nbsd-tdep.o"
> +			alpha-netbsd-tdep.o alpha-obsd-tdep.o netbsd-tdep.o"
>  	;;
>  
>  am33_2.0*-*-linux*)
> @@ -632,14 +632,14 @@ sparc64-*-netbsd* | sparc64-*-knetbsd*-gnu)
>  sparc-*-openbsd*)
>  	# Target: OpenBSD/sparc
>  	gdb_target_obs="sparc-tdep.o sparc-netbsd-tdep.o sparc-obsd-tdep.o \
> -			nbsd-tdep.o bsd-uthread.o \
> +			netbsd-tdep.o bsd-uthread.o \
>  			ravenscar-thread.o sparc-ravenscar-thread.o"
>  	;;
>  sparc64-*-openbsd*)
>  	# Target: OpenBSD/sparc64
>  	gdb_target_obs="sparc64-tdep.o sparc64-netbsd-tdep.o sparc64-obsd-tdep.o \
>  			sparc-tdep.o sparc-netbsd-tdep.o sparc-obsd-tdep.o \
> -			nbsd-tdep.o bsd-uthread.o \
> +			netbsd-tdep.o bsd-uthread.o \
>  			ravenscar-thread.o sparc-ravenscar-thread.o"
>  	;;
>  sparc-*-solaris2* | sparcv9-*-solaris2* | sparc64-*-solaris2*)

It sounds like the changes in configure.tgt are not like the others
(cosmetic changes in comments) but would in fact fix a build failure
when GDB is built with, say, --target=sparc64-something-openbsd (I don't
know what the actual triplets look like).  But using that gives me:

    $ make
    make: *** No rule to make target 'nbsd-tdep.c', needed by 'nbsd-tdep.o'.  Stop.

So, please mention this in the commit message, it's an important point.

Simon