[PATCH] gdb/tui: remove special handling of locator/status window

Tom Tromey tom@tromey.com
Wed Jan 27 21:33:45 GMT 2021


>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> In this patch I propose splitting the two roles of the
Andrew> tui_locator_window class.  The tui_locator_window class will retain
Andrew> just its window drawing parts, and will be treated just like any other
Andrew> window.  This should allow all special case code for this window to be
Andrew> deleted.

Thanks for doing this.  I think it's a good idea.

I had a couple of nits.

Andrew> +/* Class used to track the current location that the TUI is displaying.  An
Andrew> +   instance of this class will be created, then, as events occur within GDB

I guess I'd use a semicolon or period before "then".

Andrew> +   the location information within this instance will be updated.  As
Andrew> +   windows like the status window, source window, or disassembler winder

s/winder/window/

Tom


More information about the Gdb-patches mailing list