[PATCH] gdb: Use correct feature in tdesc-regs for ARC

[Shahab Vahedi]

Hi Andrew,

On Tue, Jan 26, 2021 at 09:17:36AM +0000, Andrew Burgess wrote:
> * Shahab Vahedi via Gdb-patches <gdb-patches@sourceware.org> [2021-01-26 00:02:44 +0100]:
> 
> >      "arc*-*-*" {
> >  	set architecture "arc:ARCv2"
> > -	set core-regs {arc-v2.xml}
> > +	set regdir "arc/"
> > +	set core-regs {core-v2.xml aux-v2.xml}
> 
> Maybe I'm either going crazy, or really don't understand this test (do
> please correct me), but the contents of gdb/features/arc/ on current
> master are:
> 
>   $ ls gdb/features/arc/
>   v1-aux.c  v1-aux.xml  v1-core.c  v1-core.xml  v2-aux.c  v2-aux.xml  v2-core.c  v2-core.xml
> 
> So shouldn't this be:
> 
>   set core-regs {v2-core.xml v2-aux.xml}
> 
> But for a change to only one test file, surely this was tested, right?
> So how was it passing for you?

You're absolutely right!  This was a snafu on my side.  This fix happened
chronologically before ARC's XML feature patch [1] evolve to its final form.
I've had marked the previously submitted patch [2] as "ready for upstream"
in my backlog commits and did not execute the tests again.  I sincerely
apologise for that.

The new patch is submitted again [3] along with the test results in the
commit message.

[1] arc: Add ARCv2 XML target along with refactoring
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=995d3a197d7a

[2] [PATCH] gdb: Use correct feature in tdesc-regs for ARC
https://sourceware.org/pipermail/gdb-patches/2021-January/175458.html

[3] [PATCH v2] gdb: Use correct feature in tdesc-regs for ARC
https://sourceware.org/pipermail/gdb-patches/2021-January/175476.html


Cheers,
Shahab