[PATCH 2/2] gdb/testsuite: rename _cur_x/_cur_y to _cur_col/_cur_row in lib/tuiterm.exp
Simon Marchi
simon.marchi@polymtl.ca
Wed Jan 20 21:11:01 GMT 2021
On 2021-01-11 3:56 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Simon> I am having trouble remembering which of _cur_x/_cur_y is columns and
> Simon> which is rows, so renaming them helps. We already have _rows and _cols
> Simon> to represent the terminal size, so I think that makes sense to name the
> Simon> "_cur" variables accordingly.
>
> Hah, i have the opposite problem, where "x" and "y" are clear but I
> have to think about row/column.
Oh well... the important thing is that we use consistent naming!
> Simon> gdb/testsuite/ChangeLog:
>
> Simon> * lib/tuiterm.exp: Rename _cur_x/_cur_y to _cur_col/_cur_row.
>
> Looks good. Thanks.
>
> Tom
Ok, thanks, I'll push it.
Simon
More information about the Gdb-patches
mailing list