[PATCH 1/5] gdb: change jit_debug to a bool

Simon Marchi simon.marchi@polymtl.ca
Wed Jan 13 15:49:54 GMT 2021


On 2021-01-13 9:32 a.m., Shahab Vahedi wrote:
> Hi Simon,
> 
> This patch looks fine to me with a minor comment.
> 
> Simon Marchi wrote:
>>  static void
>>  show_jit_debug (struct ui_file *file, int from_tty,
>> @@ -1251,13 +1251,13 @@ _initialize_jit ()
>>  {
>>    jit_reader_dir = relocate_gdb_directory (JIT_READER_DIR,
>>  					   JIT_READER_DIR_RELOCATABLE);
>> -  add_setshow_zuinteger_cmd ("jit", class_maintenance, &jit_debug,
>> -			     _("Set JIT debugging."),
>> -			     _("Show JIT debugging."),
>> -			     _("When non-zero, JIT debugging is enabled."),
>> -			     NULL,
>> -			     show_jit_debug,
>> -			     &setdebuglist, &showdebuglist);
>> +  add_setshow_boolean_cmd ("jit", class_maintenance, &jit_debug,
>> +			   _("Set JIT debugging."),
>> +			   _("Show JIT debugging."),
>> +			   _("When non-zero, JIT debugging is enabled."),
> "When set, JIT debugging is enabled."

Good point, fixed.  I'll push the patch with that fixed, it's probably
not too controversial anyway.

Thanks!

Simon


More information about the Gdb-patches mailing list