[PATCH 06/12] Factor out after-stop event handling code from stop_all_threads

Simon Marchi simon.marchi@polymtl.ca
Wed Jan 13 06:06:22 GMT 2021


On 2021-01-12 8:15 p.m., Pedro Alves wrote:
> This moves the code handling an event out of wait_one to a separate
> function, to be used in another context in a following patch.
> 
> gdb/ChangeLog:
> 
> 	* infrun.c (handle_one): New function, factored out from ...
> 	(stop_all_threads): ... here.

I think this is a good cleanup on its own, that function was starting to
get crowded.  Since that removes a few indentation levels to the code, it
would be nice to un-wrap it a little bit, that would help readability.

Could you document the meaning of the return value of handle_one in its
top comment?

Otherwise, that LGTM.

Simon


More information about the Gdb-patches mailing list