[PATCH][gdb/remote] Fix invalid pointer in remote_async_serial_handler

Simon Marchi simon.marchi@polymtl.ca
Thu Jan 7 16:29:29 GMT 2021



On 2021-01-07 11:27 a.m., Tom de Vries wrote:
> Hi Andrew,
> 
> [ cc-ing Simon again ]
> 
> Simon did mention in the discussion in the PR that he would submit the
> series, so yes, I was aware of that.
> 
>> You said above that your patch is proposed for gdb-10-branch, but also
>> that it could be applied to master.  I think that this would be fine
>> applied to the gdb-10-branch,
> Thanks for the review.
> 
>> but I think Simon's fix would be better
>> for master.
>>
> Sure, that's fine by me.
> 
> I just wanted to mention the possibility of committing this to master,
> and let others decide whether that's a good idea.
> 
>> Though that said, I notice your credit Simon & Pedro in the ChangeLog,
>> so maybe they've expressed a preference for this solution somewhere
>> and I've just missed it?
> The patch was written by Pedro, and Simon provided the trigger patch.
> The patch was discussed as possibility for gdb-10-branch, and this is
> the submission for that.
> 
> Hope this clarifies things a bit.
> 
> Thanks,
> - Tom

I agree that the refcount patch would be good for GDB 10, it's less
invasive.  I still intend to merge my patch series in master, but I
am waiting for an ack from Pedro, who is quite busy at the moment.

Simon


More information about the Gdb-patches mailing list