[PATCH] sim: cris: disable test that crashes the linker

Andrew Burgess andrew.burgess@embecosm.com
Thu Jan 7 09:36:25 GMT 2021


* Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org> [2021-01-07 01:59:31 -0500]:

> PR ld/13900
> Linking this test crashes the linker, so disable it.  The crash
> was reported about 9 years ago but haven't made progress, so lets
> avoid the failures in test runs.
> ---
>  sim/testsuite/sim/cris/ChangeLog     | 5 +++++
>  sim/testsuite/sim/cris/c/helloaout.c | 6 +++++-
>  2 files changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/sim/testsuite/sim/cris/ChangeLog b/sim/testsuite/sim/cris/ChangeLog
> index 5ff077c486d1..e9444bd18d82 100644
> --- a/sim/testsuite/sim/cris/ChangeLog
> +++ b/sim/testsuite/sim/cris/ChangeLog
> @@ -1,3 +1,8 @@
> +2021-01-07  Mike Frysinger  <vapier@gentoo.org>
> +
> +	PR ld/13900
> +	* c/helloaout.c: Disable test
> +

LGTM.

Thanks,
Andrew

>  2021-01-07  Mike Frysinger  <vapier@gentoo.org>
>  
>  	* c/c.exp [cris*-*-elf] (CFLAGS_FOR_TARGET): Add -sim.
> diff --git a/sim/testsuite/sim/cris/c/helloaout.c b/sim/testsuite/sim/cris/c/helloaout.c
> index 0f774593121e..c71a658c18c7 100644
> --- a/sim/testsuite/sim/cris/c/helloaout.c
> +++ b/sim/testsuite/sim/cris/c/helloaout.c
> @@ -4,7 +4,11 @@
>     doesn't help.  Adjust as needed to get a.out which says "pass".  If
>     necessary, move to the asm subdir.  By design, it doesn't work with
>     CRIS v32.)
> -#target: cris-*-elf
> +
> +NB: We'd rely on kfail, but that doesn't skip compilation, and that's where
> +the crash in ld happens to break the testcase.
> +#target: disabled-cris-*-elf
> +#kfail: ld/13900 cris-*-elf
>  #cc: ldflags=-Wl,-mcrisaout\ -sim\ -Ttext=0
>  */
>  #include "hello.c"
> -- 
> 2.28.0
> 


More information about the Gdb-patches mailing list