[PATCH 2/3] Don't fill regs window with a negative number of spaces

Hannes Domani ssbssa@yahoo.de
Tue Jan 5 16:30:25 GMT 2021


Function n_spaces can't handle negative values, and returns an invalid
pointer in this case.

gdb/ChangeLog:

2021-01-05  Hannes Domani  <ssbssa@yahoo.de>

	* tui/tui-regs.c (tui_data_item_window::rerender): Don't call
	n_spaces with a negative value.
---
 gdb/tui/tui-regs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c
index 78cb2099746..5caff7195ef 100644
--- a/gdb/tui/tui-regs.c
+++ b/gdb/tui/tui-regs.c
@@ -492,7 +492,8 @@ tui_data_item_window::rerender (WINDOW *handle, int field_width)
     (void) wstandout (handle);
       
   mvwaddnstr (handle, y, x, content.c_str (), field_width - 1);
-  waddstr (handle, n_spaces (field_width - content.size ()));
+  if (content.size () < field_width)
+    waddstr (handle, n_spaces (field_width - content.size ()));
 
   if (highlight)
     /* We ignore the return value, casting it to void in order to avoid
-- 
2.29.2



More information about the Gdb-patches mailing list